Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing abi for singleton with non-table type #178

Merged
merged 2 commits into from
May 18, 2023
Merged

fixing abi for singleton with non-table type #178

merged 2 commits into from
May 18, 2023

Conversation

dimas1185
Copy link
Contributor

fixes #155

Change Description

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@dimas1185 dimas1185 mentioned this pull request May 16, 2023
Closed
@mikelik
Copy link
Member

mikelik commented May 17, 2023

I have 3 errors in integration tests:

Running 17 test cases...
�[33m3015004 invalid_type_inside_abi: The type defined in the ABI is invalid
code_hash
    {"type":"code_hash"}
    integration_tes  abi_serializer.cpp:305 validate

    {"t":["code.hash","code_hash"]}
    integration_tes  abi_serializer.cpp:306 validate

    {}
    integration_tes  tester.cpp:695 get_action

    {"code":"test","acttype":"theaction","auths":[{"actor":"test","permission":"active"}],"data":{},"expiration":6,"delay_sec":0}
    integration_tes  tester.cpp:677 push_action
rethrow
    {}
    integration_tes  get_code_hash_tests.cpp:42 test_method
�[0m
/home/mikel/repo/cdt/tests/integration/main.cpp(16): �[4;31;49mfatal error: in "get_code_hash_tests_suite/get_code_hash_tests": Caught Unexpected Exception�[0;39;49m
�[33m3015004 invalid_type_inside_abi: The type defined in the ABI is invalid
record_idx128
    {"type":"record_idx128"}
    integration_tes  abi_serializer.cpp:305 validate

    {"t":["autoinctbl1","record_idx128"]}
    integration_tes  abi_serializer.cpp:306 validate

    {}
    integration_tes  tester.cpp:695 get_action

    {"code":"testapi","acttype":"s1g","auths":[{"actor":"testapi","permission":"active"}],"data":{},"expiration":6,"delay_sec":0}
    integration_tes  tester.cpp:677 push_action
rethrow
    {}
    integration_tes  multi_index_tests.cpp:73 test_method
�[0m
/home/mikel/repo/cdt/tests/integration/main.cpp(16): �[4;31;49mfatal error: in "multi_index_tests/main_multi_index_tests": Caught Unexpected Exception�[0;39;49m
�[33m3015004 invalid_type_inside_abi: The type defined in the ABI is invalid
name_table
    {"type":"name_table"}
    integration_tes  abi_serializer.cpp:305 validate

    {"t":["name.pk","name_table"]}
    integration_tes  abi_serializer.cpp:306 validate

    {}
    integration_tes  tester.cpp:695 get_action

    {"code":"test","acttype":"write","auths":[{"actor":"test","permission":"active"}],"data":{},"expiration":6,"delay_sec":0}
    integration_tes  tester.cpp:677 push_action
rethrow
    {}
    integration_tes  name_pk_tests.cpp:28 test_method
�[0m
/home/mikel/repo/cdt/tests/integration/main.cpp(16): �[4;31;49mfatal error: in "name_pk_tests_suite/name_pk_tests": Caught Unexpected Exception�[0;39;49m

�[1;31;49m*** 3 failures are detected in the test module "Master Test Suite"

@dimas1185
Copy link
Contributor Author

I have 3 errors in integration tests:

thanks. fixed. you'll need to fully rebuild or make tests rebuild to check. those are not automatically rebuilt if you just pull changes. that is why those passed for me. I've got a fail only after full rebuild

@dimas1185 dimas1185 merged commit e3ef75c into main May 18, 2023
@dimas1185 dimas1185 deleted the fix-abi-singleton branch May 18, 2023 21:47
@ericpassmore ericpassmore added this to the CDT 4.1.0-rc1 milestone Dec 21, 2023
@ericpassmore
Copy link
Contributor

Note:start
group: STABILITY
category: BUG
summary: Fix ABI to generate tables for singleton without struct.
Note:end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottBailey ScottBailey ScottBailey approved these changes

@mikelik mikelik mikelik approved these changes

@pliuwu1998 pliuwu1998 pliuwu1998 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
CDT 4.1.0-rc1
Development

Successfully merging this pull request may close these issues.

Singletons without structs do not generate tables in the ABI
5 participants
@dimas1185 @mikelik @ericpassmore @ScottBailey @pliuwu1998